Is your feature request related to a problem? Please describe
No.
Describe the solution you'd like
We are the authors of PKI.js and ASN.1js and were looking at projects that took a dependency on our libraries so I started looking at consumers like njs-acme.
We noticed that you import ASN.js but implement your own ASN.1 reader.
Though we didn't see any issues in your ASN.1 reader we also didn't look very closely. In general, parsers are a pain to get right and since you take the dependency and use it in some places you could make a relatively simple change to reduce to complexity of your code by using our reader in all places vs maintaining two implementations as a dependency.
Is your feature request related to a problem? Please describe
No.
Describe the solution you'd like
We are the authors of PKI.js and ASN.1js and were looking at projects that took a dependency on our libraries so I started looking at consumers like
njs-acme.We noticed that you import ASN.js but implement your own ASN.1 reader.
Though we didn't see any issues in your ASN.1 reader we also didn't look very closely. In general, parsers are a pain to get right and since you take the dependency and use it in some places you could make a relatively simple change to reduce to complexity of your code by using our reader in all places vs maintaining two implementations as a dependency.
Describe alternatives you've considered
This is just a suggestion.
Additional context
N/A