nginx / njs-acme

Nginx NJS module runtime to work with ACME providers like Let's Encrypt for automated no-reload TLS certificate issue/renewal.
Apache License 2.0
60 stars 9 forks source link

Dev environment + Typescript + Variables Improvements #5

Closed zsteinkamp closed 1 year ago

zsteinkamp commented 1 year ago
ivanitskiy commented 1 year ago

LGTM with a few minor comments.

ivanitskiy commented 1 year ago

I see a missing part here, an updated examples/nginx.conf file, which documents all newly introduced (request)variables and associated env var and their respective defaults.