Closed jo-carter closed 3 weeks ago
Keyval_zone has the same feature for updates over the N+ API, for reference: https://nginx.org/en/docs/http/ngx_http_api_module.html#def_nginx_http_keyval_zone_post_patch
@xeioex Thank you for the review and patches provided. 100% agreed on all your points regarding style, formatting, tests. and the commit message.
I made two small adjustments to the patches you provided:
Let me know what you think of these adjustments.
@xeioex Thanks again :)
The optional timeout argument overrides the timeout specified with the shared_dict_zone directive for the effected key and operation only. The timeout is specified in milliseconds.
This is useful when the majority of keys are expected to require unique timeouts.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTING
document