search

nginx / unit-docs

NGINX Unit's official website and documentation
https://unit.nginx.org
Creative Commons Attribution 4.0 International
50 stars 99 forks source link

Fix dockerfile make command #84

Closed ac000 closed 4 months ago

ac000 commented 4 months ago

In the make command it should be VERSIONS_ (plural).

netlify[bot] commented 4 months ago

Deploy Preview for nginx-unit ready!

Built without sensitive environment variables

Name Link
Latest commit 56673325a2d36cac7f26838ab5eec760b8180a67
Latest deploy log https://app.netlify.com/sites/nginx-unit/deploys/65a93e51e0e4fe00089aa176
Deploy Preview https://deploy-preview-84--nginx-unit.netlify.app/howto/falcon
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thresheek commented 4 months ago

Indeed, that looks correct for the contemporary images since https://github.com/nginx/unit/commit/6e548cbb30c0035b0d377dced7564522fba4eff3

ac000 commented 4 months ago

Rebased with master and added Konstantins Reviewed-by: tag.

$ git range-diff 64d3979...429b296
-:  ------- > 1:  b757a77 Replace Homebrew section with macOS section
-:  ------- > 2:  b7d2e06 Update copyright year
1:  64d3979 ! 3:  429b296 Fix dockerfile make command
    @@ Commit message

         Reported-by: tclesius <https://github.com/tclesius>
         Closes: https://github.com/nginx/unit-docs/issues/76
    +    Reviewed-by: Konstantin Pavlov <thresh@nginx.com>
         Signed-off-by: Andrew Clayton <a.clayton@nginx.com>

      ## source/installation.rst ##
ac000 commented 4 months ago

Added Timo's Reviewed-by: tag...

$ git range-diff 429b296...5667332
1:  429b296 ! 1:  5667332 Fix dockerfile make command
    @@ Commit message
         Reported-by: tclesius <https://github.com/tclesius>
         Closes: https://github.com/nginx/unit-docs/issues/76
         Reviewed-by: Konstantin Pavlov <thresh@nginx.com>
    +    Reviewed-by: Timo Stark <t.stark@nginx.com>
         Signed-off-by: Andrew Clayton <a.clayton@nginx.com>

      ## source/installation.rst ##