nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.
https://unit.nginx.org
Apache License 2.0
5.26k stars 322 forks source link

Docker: redirect logs to stderr #1128

Closed thresheek closed 4 months ago

thresheek commented 4 months ago

This allows to use /dev/stdout as application logs if users choose to do so.

Fixes https://github.com/nginx/unit/issues/982

ac000 commented 4 months ago

Please use Closes: instead of Fixes. We're using Fixes: for when referring back to previous commits that introduced some issue.

ac000 commented 4 months ago

No need for the trailing . on the subject line.

thresheek commented 4 months ago

Removed trailing dot on the subject line, and changed wording to use 'Closes:' instead.

Thanks!

callahad commented 4 months ago

This seems somewhat weird to me, but it's a small and relatively innocuous change. We'll want to include it in the release notes and come back around to more sophisticated logging configurations when we address #973

callahad commented 4 months ago

We'll also need to regenerate all Dockerfiles from the template, but there are a few other incoming Docker changes that I'm about to merge. I'll regenerate once those are all in.