search

nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.
https://unit.nginx.org
Apache License 2.0
5.37k stars 323 forks source link

Docker: Switch python3.12 to using github #1137

Closed andrey-zelenkov closed 7 months ago

andrey-zelenkov commented 7 months ago

Forgotten in https://github.com/nginx/unit/commit/c3af21e970ca3c822004cfda7c5b56ec07d99da9

callahad commented 7 months ago

Forgotten in c3af21e970ca3c822004cfda7c5b56ec07d99da9

Not so much forgotten... It's more the product of out-of-order merges.

1050 added python 3.12

1131 switched the Dockerfiles to git

...but #1131 was based on master before #1050 was merged, so its regenerated the Dockerfiles didn't include 3.12.

We're actually in an inconsistent state right now, because https://github.com/nginx/unit/commit/822303e23cb489efdc4fa3ca321f8468a2dd17fa effectively bumped NXT_VERSION to 1.32.0, which is used in make dockerfiles, so you either have to edit that or override the variable when regenerating the Dockerfiles locally.

And we're likely to have more inconsistencies once we merge #1127.

I wonder if the answer is to stop tracking the generated Dockerfiles in our repo?

ac000 commented 7 months ago

I asked this before... https://github.com/nginx/unit/issues/1009#issuecomment-1846037342

callahad commented 7 months ago

Oof. Thank you for the citation. So I guess the next best thing is a CI job that verifies that regenerating our Dockerfiles is a no-op. Will file an issue to think this through later.

thresheek commented 7 months ago

That, and a separate job to actually test the dockerfiles when a change arrives. So far it's a manual check with hacks on top to checkout the commit you need.