nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.
https://unit.nginx.org
Apache License 2.0
5.37k stars 323 forks source link

njs (lowercase) is more preferred way to mention #1208

Closed andrey-zelenkov closed 5 months ago

andrey-zelenkov commented 6 months ago

This wants splitting up. At least keep the "docs" changes separate from the "code" changes...

I am considering this as a global update similar to the copyright update here: https://github.com/nginx/unit/pull/1103/files, which wasn't split into docs/code/pkg/tools sections. So, I see no reason to split it up here.

ac000 commented 6 months ago

Past experience shows that anything that changes the changelog should be done in a separate commit.

andrey-zelenkov commented 5 months ago

Split into two commits:

% git range-diff 009fac08...bf72069b
-:  -------- > 1:  d24c1c44 njs (lowercase) is more preferred way to mention
-:  -------- > 1:  d24c1c44 njs (lowercase) is more preferred way to mention
1:  009fac08 ! 2:  bf72069b njs (lowercase) is more preferred way to mention
    @@ Metadata
     Author: Andrei Zeliankou <zelenkov@nginx.com>
-:  -------- > 1:  d24c1c44 njs (lowercase) is more preferred way to mention
1:  009fac08 ! 2:  bf72069b njs (lowercase) is more preferred way to mention
    @@ Metadata
     Author: Andrei Zeliankou <zelenkov@nginx.com>

      ## Commit message ##
    -    njs (lowercase) is more preferred way to mention
    +    Docs: njs (lowercase) is more preferred way to mention

      ## CHANGES ##
     @@ CHANGES: Changes with Unit 1.32.0                                         27 Feb 2024
    @@ CHANGES: Changes with Unit 1.29.1                                         28 Feb
          *) Bugfix: path parsing in PHP applications.

    - ## auto/help ##
    -@@ auto/help: cat << END
    - 
    -   --openssl            enable OpenSSL library usage
    - 
    --  --njs                enable NJS library usage
    -+  --njs                enable njs library usage
    - 
    -   --debug              enable debug logging
    - 
    -
-:  -------- > 1:  d24c1c44 njs (lowercase) is more preferred way to mention
1:  009fac08 ! 2:  bf72069b njs (lowercase) is more preferred way to mention
    @@ Metadata
     Author: Andrei Zeliankou <zelenkov@nginx.com>

      ## Commit message ##
    -    njs (lowercase) is more preferred way to mention
    +    Docs: njs (lowercase) is more preferred way to mention

      ## CHANGES ##
     @@ CHANGES: Changes with Unit 1.32.0                                   
      27 Feb 2024
    @@ CHANGES: Changes with Unit 1.29.1                                    
     28 Feb
          *) Bugfix: path parsing in PHP applications.

    - ## auto/help ##
    -@@ auto/help: cat << END
    - 
    -   --openssl            enable OpenSSL library usage
    - 
    --  --njs                enable NJS library usage
    -+  --njs                enable njs library usage
    - 
    -   --debug              enable debug logging
    - 
    -
    - ## auto/njs ##
    -@@ auto/njs: else
    -     NXT_NJS_LIBS="-lnjs"
    - fi
    - 
    --nxt_feature="NJS"
    -+nxt_feature="njs"
    - nxt_feature_name=NXT_HAVE_NJS
    - nxt_feature_run=no
    - nxt_feature_incs="$NXT_NJS_CFLAGS $NXT_NJS_AUX_CFLAGS"
    -@@ auto/njs: nxt_feature_libs="$NXT_NJS_LIBS $NXT_NJS_AUX_LIBS"
    - nxt_feature_test="#include <njs.h>
    - 
    -                   #if NJS_VERSION_NUMBER < 0x000803
    --                  # error NJS < 0.8.3 is not supported.