search

nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.
https://unit.nginx.org
Apache License 2.0
5.37k stars 323 forks source link

HTTP: Fixed missed parsing test #1217

Closed hongzhidao closed 5 months ago

hongzhidao commented 5 months ago

This issue was introduced in the commit 64934e5.

ac000 commented 5 months ago

You can get rid of the commit message and put instead...

Fixes: 64934e59f ("HTTP: Introduce quoted target marker in HTTP parsing")
Reviewed-by: Andrew Clayton <a.clayton@nginx.com>

Feel free to append your Signed-off-by: (once we've officially adopted the DCO this will become mandatory anyway)...

ac000 commented 5 months ago

OK, so that went completely wrong!

What I suggested to do was this

commit 678c05686996e0aa6ddf79bf71279425306e9113
Author: Zhidao HONG <z.hong@f5.com>
Date:   Tue Apr 16 23:30:15 2024 +0800

    HTTP: Fixed missed parsing test

    Fixes: 64934e59f ("HTTP: Introduce quoted target marker in HTTP parsing")
    Reviewed-by: Andrew Clayton <a.clayton@nginx.com>
    Signed-off-by: Zhidao HONG <z.hong@f5.com>

What we ended up with is this

commit 678c05686996e0aa6ddf79bf71279425306e9113
Author: Zhidao HONG <z.hong@f5.com>
Date:   Tue Apr 16 23:30:15 2024 +0800

    Fixes: 64934e59f ("HTTP: Introduce quoted target marker in HTTP parsing")
    Reviewed-by: Andrew Clayton <a.clayton@nginx.com>

The Fixes tag has ended up as the Subject and there is no blank line separating it from the body.

Maybe I confused you when I said message when I obviously just meant the body,,,

Oh, well, that'll teach me not to approve things before I've seen the requested changes...