search

nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.
https://unit.nginx.org
Apache License 2.0
5.25k stars 321 forks source link

Docker via CLI #1241

Closed avahahn closed 1 month ago

avahahn commented 1 month ago

This PR adds functionality to the CLI to support its existing functionality used with Docker deployments of Unit. In addition to that, a new subcommand is added that offers a procedure to deploy any unit docker image with user defined mounts for the control socket and any application of choice. Finally, unitctl codebase is refactored to simply handling of async futures, relying on a standard provided runtime instead of attempting to maintain a custom future executor. Tests are added and updated as well.

ac000 commented 1 month ago

Please use the tools/unitctl: topic/prefix for the commit message subjects...

ac000 commented 1 month ago

I see a lot of UNIT's in places like the README, that should really be Unit (how it's spelt in official documentation).

ac000 commented 1 month ago

The subject of the last commit tools/unitctl: enable passing TCP addresses to unitctl instances new is a little confusing.

AIUI 'instances new' is a command. If so how about

tools/unitctl: Enable passing IP addresses to the 'instances new' command

Also s/TCP/IP/

(it's bordering a little on the long side, but ...)