CLI: `unitctl edit` should get editor from environment variables

nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.

https://unit.nginx.org

Apache License 2.0

5.25k stars 321 forks source link

CLI: `unitctl edit` should get editor from environment variables #1253

Closed avahahn closed 1 month ago

avahahn commented 1 month ago

Currently unitctl edit picks an editor form a list of known paths. It has the logic to select from environment variables including EDITOR and VISUAL but that logic isnt called.

ac000 commented 1 month ago

I didn't check the code but it should try $VISUAL then $EDITOR then fallback to something standard like vi(1)

avahahn commented 1 month ago

Closing as additional testing revealed that this logic was working as expected. Sorry for the noise!