search

nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.
https://unit.nginx.org
Apache License 2.0
5.25k stars 321 forks source link

Add unitctl build and release CI #1257

Closed arbourd closed 1 month ago

arbourd commented 1 month ago

Adds a GitHub Actions workflow that builds and releases unitctl binaries when a tag prefixed with unitctl/ is pushed.

Binaries are built on pull-requests that change any files within tools/unitctl, on master branch pushes and when unitctl/ prefixed tags are pushed.

Screenshot 2024-05-09 at 2 30 03 PM
callahad commented 1 month ago

On the unitctl/x.y.z tag namespace... Do we want to have distinct versioning for unitctl, or do we want to bind its version to Unit releases?

ac000 commented 1 month ago

To echo Dan's sentiments.

We have tags depicting Unit releases. Do we want to pollute that with other tags?.

Is there a very good reason not to just tie it off Unit releases?.

I.e I expect to see (and I don't know if we have tooling that expects the same)

$ git describe
1.32.0-72-g5d1ce5c4

The only thing you could do is use a lightweight tag, but that's not really correct as they aren't supposed to be distributed (although we do use them for the packaging tags), but I think you need a really good reason for it to have its own tags.

avahahn commented 1 month ago

I am happy to tie it to unit releases. Currently testing a patch to do just that.

ac000 commented 1 month ago

What was the rush?

This should have been committed as a single commit.

We don't commit things in a known broken/incorrect/intermediary state immediately followed by fix up commits...