Open andrey-zelenkov opened 1 month ago
LGTM.
Do we want to apply this now or wait until the next njs version is released?
I'd suggest waiting for it until the next njs version is released, perhaps there are more changed APIs.
For context, the current release is 0.8.4 so we're waiting for something 0.8.5 to get tagged.
njs changed strings API so now instead of
njs_vm_value_string_set()
usednjs_vm_value_string_create()
as a drop-in replacement.For more information see: http://hg.nginx.org/njs/rev/4e0553f7ea68