nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.
https://unit.nginx.org
Apache License 2.0
5.25k stars 320 forks source link

njs: compatibility with 0.8.5 #1293

Open andrey-zelenkov opened 1 month ago

andrey-zelenkov commented 1 month ago

njs changed strings API so now instead of njs_vm_value_string_set() used njs_vm_value_string_create() as a drop-in replacement.

For more information see: http://hg.nginx.org/njs/rev/4e0553f7ea68

hongzhidao commented 4 weeks ago

LGTM.

ac000 commented 4 weeks ago

Do we want to apply this now or wait until the next njs version is released?

hongzhidao commented 4 weeks ago

I'd suggest waiting for it until the next njs version is released, perhaps there are more changed APIs.

callahad commented 1 week ago

For context, the current release is 0.8.4 so we're waiting for something 0.8.5 to get tagged.