search

nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.
https://unit.nginx.org
Apache License 2.0
5.25k stars 322 forks source link

change in validation and set_python_target function #1335

Closed gourav-kandoria closed 1 week ago

callahad commented 1 week ago

It does match my earlier suggestion of

If you have a patch, would you mind opening a pull request? Even if it's unpolished, having something concrete is a great starting point.

😆

Great way to get the ball rolling; thank you @gourav-kandoria! Are you up for refining this to match the later proposal (a separate factory boolean in the config?)

gourav-kandoria commented 1 week ago

@callahad @ac000 oh my bad really sorry . @callahad I had these changes earlier in my local. raised pr with those changes. here is new pr as you suggested in issue comments https://github.com/nginx/unit/pull/1336/files

callahad commented 1 week ago

Great, thank you! Closing in favor of #1336