search

nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.
https://unit.nginx.org
Apache License 2.0
5.37k stars 323 forks source link

http: Fix router process crash whilst using proxy #1418

Closed hongzhidao closed 2 weeks ago

hongzhidao commented 2 weeks ago

When the client closes the connection before the upstream, the proxy's error handler was calling cleanup operation like peer close and requestclose twice, this fix ensures the cleanup is performed only once, improving proxy stability.

Closes: https://github.com/nginx/unit/issues/828

hongzhidao commented 2 weeks ago

Hi @hongzhidao

Good fix!

http: Fix router process crash whilst using proxy

When the client closes the connection before the upstream,
the proxy's error handler was calling cleanup operation like
peer close and requestclose twice, this fix ensures the cleanup
is performed only once, improving proxy stability.

Maybe requestclose should be request close?

Fixed, thanks.