search

nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.
https://unit.nginx.org
Apache License 2.0
5.37k stars 323 forks source link

unitctl binaries should have better version reporting #1427

Closed callahad closed 1 week ago

callahad commented 1 week ago

Right now unitctl --version just reports the contents of Cargo.toml, namely: "unitctl 0.4.0-beta"

Things that need to change:

  1. 0.4.0-beta is wrong; our version should follow unit's version
  2. If known, we should incorporate and report the commit hash that we built from
ac000 commented 1 week ago

Hmm, this version is in quite a few places...

openapi-config.json:3:  "packageVersion": "0.4.0-beta",
unit-client-rs/Cargo.toml:3:version = "0.4.0-beta"
unit-openapi/Cargo.toml:3:version = "0.4.0-beta"
unit-openapi/README.md:24:- Package version: 0.4.0-beta
unitctl/Cargo.toml:4:version = "0.4.0-beta"
Cargo.lock:2024:version = "0.4.0-beta"
Cargo.lock:2047:version = "0.4.0-beta"
Cargo.lock:2061:version = "0.4.0-beta"
javorszky commented 1 week ago

unitctl version should be tied to the version of unit being released

and we should mark the first release of unitctl as a tech preview

ac000 commented 1 week ago

The unitctl version update is here.