Open callahad opened 2 months ago
It says "UNIT" in a few places
This should be part of https://github.com/nginx/unit/commit/f4d3e2ffd51c2aacbdb194affe948af50db46287.patch
Cc: @javorszky
Author field should be some collective ("The NGINX Unit Team" instead of Elijah)
unit-openapi/Cargo.toml:4:authors = ["unit-owner@nginx.org"]
Who gets that email?
Elijah's name appears in a few places
tools/unitctl/man/unitctl.1:20:Elijah Zupancic \fB<e.zupancic@f5.com>\fR
tools/unitctl/unit-client-rs/Cargo.toml:4:authors = ["Elijah Zupancic"]
tools/unitctl/unitctl/Cargo.toml:5:authors = ["Elijah Zupancic"]
I'm a little uneasy just removing his authorship. At the very least I'd want his s-o-b
for making this change...
Cc: @dekobon
Please make me the SOB responsible for this. Actually, I don't know what s-o-b
is.
Definitely remove me from the man page.
As for Cargo.toml
, isn't the custom to add all of the major contributors? Feel free to take me out because I won't be much of a contributor going forward.
s-o-b is short for Signed-off-by
Sure, happy to sign off.
As for
Cargo.toml
, isn't the custom to add all of the major contributors?
Yes, happy to do it that way.
OK, so I did kind of forget about this but then it is also not clear what to do about the unit-owner@nginx.org
email address which appears in a few places
docs/unit-openapi.yaml:33: email: "unit-owner@nginx.org"
tools/unitctl/unit-openapi/Cargo.toml:4:authors = ["unit-owner@nginx.org"]
tools/unitctl/unit-openapi/README.md:409:unit-owner@nginx.org
This email address goes to Sergey B. Probably not useful... We could use unit@nginx.org, the mailing list, but that requires you to be registered with the list.
Then there is what to put in the unitctl man-page, we could just put the same stuff that's in the unit man-page.