search

nginxinc / ansible-role-nginx

Ansible role for installing NGINX
https://galaxy.ansible.com/nginxinc/nginx
Apache License 2.0
644 stars 348 forks source link

Nginx will not install on FreeBSD #711

Closed kadecole closed 6 months ago

kadecole commented 6 months ago

Describe the bug

Install Task is skipped on FreeBSD.

TASK [nginxinc.nginx : (DragonFlyBSD/FreeBSD/HardenedBSD) Install NGINX package] ******************************************************************************** skipping: [freebsd-server]

To reproduce

Steps to reproduce the behavior:

  1. Deploy the Ansible NGINX role using playbook.yml
  2. View output/logs/configuration on ...
  3. See error

skipping: [freebsd-server] => {"changed": false, "false_condition": "ansible_facts['system'] in ['DragonFlyBSD', 'FreeBSD' 'HardenedBSD']", "skip_reason": "Conditional result was False"}

Expected behavior

Nginx package should be installed.

Your environment

Additional context

There is a missing comma in the when statement in the following file on Line 18: https://github.com/nginxinc/ansible-role-nginx/blob/main/tasks/opensource/install-bsd.yml#L18

Currently reads: when: ansible_facts['system'] in ['DragonFlyBSD', 'FreeBSD' 'HardenedBSD']

Should read: when: ansible_facts['system'] in ['DragonFlyBSD', 'FreeBSD', 'HardenedBSD']