nginxinc / crossplane

Quick and reliable way to convert NGINX configurations into JSON and back.
Apache License 2.0
719 stars 87 forks source link

Plugin system + Lua code blocks #32

Closed Raymond26 closed 6 years ago

Raymond26 commented 6 years ago
aluttik commented 6 years ago

Wow! Really great work here :)

Before I merge, I'd like to try and trick your lexer changes.

Could you add an upstream block to one of the lua test configs that looks like this?

upstream content_by_lua_block {
    # stuff
}

I want to make sure the { gets read as a token instead of being consumed as part of a lua block.

Raymond26 commented 6 years ago

Thanks! I added that and it looks like { gets read as a token works fine. But I just found that comment parsing/build doesn't work... gonna check that out

Raymond26 commented 6 years ago

Oh, just forgot the comment=True flag

gshulegaard commented 6 years ago

:field_hockey::dash: (pending final :dash: from @aluttik)

aluttik commented 6 years ago

:100::dash: