search

nginxinc / crossplane

Quick and reliable way to convert NGINX configurations into JSON and back.
Apache License 2.0
719 stars 87 forks source link

parse --include-comments and build back issue #57

Closed Taymindis closed 5 years ago

Taymindis commented 5 years ago

I am having a issue when parse --include comments and build back issue. the comment sign will also comment out some of line

for example :- it comments out my user root;

# This config was built from JSON using NGINX crossplane.# If you encounter any bugs please report them here:# https://github.com/nginxinc/crossplane/issuesuser root;

before parse is 

# This config was built from JSON using NGINX crossplane.
# If you encounter any bugs please report them here:
# https://github.com/nginxinc/crossplane/issues

user root;
aluttik commented 5 years ago

Nice find! I looked into it and apparently crossplane is having problems building when a file is supposed to start with comments. I'll fix that and notify you when the new patch version is uploaded to PyPI.

aluttik commented 5 years ago

The fix for this has been merged and will be included in 0.4.15