nginxinc / docker-nginx

Official NGINX Dockerfiles
BSD 2-Clause "Simplified" License
3.27k stars 1.73k forks source link

Fixed Dockerfile issues #899

Closed fabriziofiorucci closed 5 months ago

fabriziofiorucci commented 5 months ago

Proposed changes

Fixed an extra CRLF in Dockerfiles that broke them

Checklist

Before creating a PR, run through this checklist and mark each as complete:

thresheek commented 5 months ago

Hi @fabriziofiorucci !

What do you mean the files are broken? This part definitely did not change for quite some time (for some templates it's actually since 2020 at least) - and the CI tests confirm that. I would appreciate if you elaborate on what this fixes.

fabriziofiorucci commented 5 months ago

Hi @thresheek the current dockerfiles don't build correctly since there is an extra CRLF + several white spaces after the %%PACKAGES%% section.

thresheek commented 5 months ago

That's not true as per https://github.com/nginxinc/docker-nginx/actions/runs/9348178561/job/25726802487 and local testing. Can you show how it fails?

fabriziofiorucci commented 5 months ago

You're correct: my fault while testing. Closing the PR