search

nginxinc / kic-reference-architectures

MARA: Modern Application Reference Architecture
Apache License 2.0
633 stars 99 forks source link

chore: bump python modules to latest supported version #212

Open qdzlug opened 1 year ago

qdzlug commented 1 year ago

Describe the bug We need to bump our python modules to keep pace with the development of the Python SDK from Pulumi. The key areas that need to be updated are:

  1. Modules defined in Pipfile in the main pulumi/python directory.
  2. Modules defined in setup.py for the KIC Utilities.

To build the Pipfile.lock you can simply change the setup_venv.sh script to use update instead of sync on it's calls to pipenv. The you can revert the shell script and check in those files.

Currently, attempting to bump any of the Pulumi SDK related modules results in issues logging into the registry; this happens every time with Digital Ocean but has not be attempted with any other providers.

Errors are of the format:

    pulumi:pulumi:Stack kic-image-push-marado66 running /home/jschmidt/data/repos/kic-reference-architectures/pulumi/python/utility/kic-image-push/./registries/base_registry.py:52: RuntimeWarning: coroutine 'login_to_registry' was never awaited
    pulumi:pulumi:Stack kic-image-push-marado66 running   docker.login_to_registry(registry=registry, log_resource=None)
    pulumi:pulumi:Stack kic-image-push-marado66 running RuntimeWarning: Enable tracemalloc to get the object allocation traceback
    pulumi:pulumi:Stack kic-image-push-marado66 running Logged into container registry: https://registry.digitalocean.com
    pulumi:pulumi:Stack kic-image-push-marado66 running error: Program failed with an unhandled exception:
@ Updating....
    pulumi:pulumi:Stack kic-image-push-marado66 **failed** 1 error; 4 messages

So it does look to be something in our utility lib, but not sure what.

To Reproduce Steps to reproduce the behavior:

  1. Bump modules.
  2. Build venv.
  3. Run on DO
  4. Watch it blow up at the login to registry stage.

Expected behavior Should work.

Your environment

Additional context None

qdzlug commented 1 year ago

For reference, my hacked version of the setup script to build the lock and also to allow setting versions of utilities: https://gist.github.com/qdzlug/12cf67f7c7ca105dc0d348ae89676316

Additionally, it should be noted that we probably can drop some of the components we are building as we have not pruned this file in quite a while.