Closed brianehlert closed 5 days ago
guess this is for 3.7.0 as the change was introduced in 3.4.0? https://github.com/nginxinc/kubernetes-ingress/pull/4276/files#diff-43f7b0ca4debd314bccac5167f596b1394e23a307451e41d93ddb422c66c7d9c
Also lock name is still required but the name should be exclusively that of lease object not the configMap
As an engineer, I would like to ensure that users can deploy multiple Ingress Controllers in the same name space without modifying the name of the
leaderElectionLockName
.NOTE: This bug does not cover the lease object being managed by Helm
Changes required for fulfil requirements
_helper.tpl
to only generate the name:Before:
After:
Consideration:
charts/nginx-ingress/templates/controller-role.yaml
to usenginx-ingress.leaderElectionName
instead of.Values.controller.reportIngressStatus.leaderElectionLockName
Before:
After:
.Values.controller.reportIngressStatus.leaderElectionLockName
fromvalues.yaml
Tested two deployments in the same namespace: