search

nginxinc / kubernetes-ingress

NGINX and NGINX Plus Ingress Controllers for Kubernetes
https://docs.nginx.com/nginx-ingress-controller
Apache License 2.0
4.68k stars 1.97k forks source link

Update examples to reference a common TLS certificate #6476

Open shaun-nx opened 2 months ago

shaun-nx commented 2 months ago

Overview

Currently every example in our examples folder references the same, or similar, TLS secret for example purposes. This change is to have a common TLS certificate at the base of the examples directory that every example will reference to.

Fixes https://github.com/nginxinc/kubernetes-ingress/issues/6433

The aim is to help simplify update these example TLS certificates going forward.

### UACs
- [ ] Create common TLS certificate for all examples to reference
- [ ] Create common TLS certificate for all python tests to reference
- [ ] Create a common name for the secrets
github-actions[bot] commented 2 months ago

Hi @shaun-nx thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this :slightly_smiling_face:

Cheers!

pdabelf5 commented 2 months ago 
CN: joshvanl - Expiry: Aug 19 16:05:58 2029 GMT
tests/data/virtual-server-certmanager/ca-issuer.yaml
----
CN: NGINXIngressController - Expiry: Sep 11 18:03:35 2023 GMT
examples/shared-examples/default-server-secret/default-server-secret.yaml
tests/data/common/default-server-secret.yaml
----
CN: virtual-server.example.com - Expiry: Apr 14 14:32:47 2031 GMT
tests/data/ingress-mtls/secret/tls-secret.yaml
----
CN: cafe.example.com - Expiry: Aug 31 10:17:20 2018 GMT
tests/data/virtual-server-tls/tls-secret.yaml
tests/data/virtual-server-tls/invalid-tls-secret.yaml
tests/data/virtual-server-certmanager/tls-secret.yaml
tests/data/tls/tls-secret.yaml
tests/data/tls/invalid-tls-secret.yaml
tests/data/upgrade-test-resources/secret.yaml
tests/data/watch-secret-namespace/tls-secret.yaml
----
CN: cafe.example.com - Expiry: Jul 31 11:56:58 2018 GMT
tests/data/virtual-server-tls/new-tls-secret.yaml
tests/data/transport-server-tcp-load-balance/new-tls-secret.yaml
tests/data/wildcard-tls-secret/gb-wildcard-tls-secret.yaml
tests/data/tls/new-tls-secret.yaml
tests/data/default-server/new-tls-secret.yaml
----
CN: *.example.com - Expiry: Jan 14 02:23:31 2031 GMT
examples/custom-resources/oidc/tls-secret.yaml
examples/custom-resources/jwks/tls-secret.yaml
----
CN: app.example.com - Expiry: Mar 23 23:20:43 2023 GMT
examples/custom-resources/externalname-services/transport-server/secure-app-external.yaml
examples/custom-resources/backup-directive/transport-server/secure-app.yaml
examples/custom-resources/backup-directive/transport-server/external-secure-app.yaml
examples/custom-resources/tls-passthrough/secure-app.yaml
tests/data/transport-server-backup-service/standard/secure-app.yaml
tests/data/transport-server-tls-passthrough/standard/secure-app.yaml
----
CN: webapp.example.com - Expiry: Sep 27 22:19:59 2030 GMT
examples/custom-resources/ingress-mtls/tls-secret.yaml
----
CN: appprotect.example.com - Expiry: May 31 01:55:25 2031 GMT
tests/data/appprotect/appprotect-secret.yaml
----
CN: cafe.example.com - Expiry: Sep 11 16:15:35 2023 GMT
examples/ingress-resources/app-protect-dos/webapp-secret.yaml
examples/ingress-resources/basic-auth/cafe-secret.yaml
examples/ingress-resources/security-monitoring/cafe-secret.yaml
examples/ingress-resources/complete-example/cafe-secret.yaml
examples/ingress-resources/proxy-set-headers/mergeable-ingress/cafe-secret.yaml
examples/ingress-resources/proxy-set-headers/standard-ingress/cafe-secret.yaml
examples/ingress-resources/app-protect-waf/cafe-secret.yaml
examples/ingress-resources/mergeable-ingress-types/cafe-secret.yaml
examples/ingress-resources/rate-limit/cafe-secret.yaml
examples/custom-resources/service-insight/service-insight-secret.yaml
examples/custom-resources/cross-namespace-configuration/cafe-secret.yaml
examples/custom-resources/api-key/cafe-secret.yaml
examples/custom-resources/custom-listeners/cafe-secret.yaml
examples/custom-resources/basic-auth/cafe-secret.yaml
examples/custom-resources/external-dns/cafe-secret.yaml
examples/custom-resources/backup-directive/virtual-server/cafe-secret.yaml
examples/custom-resources/basic-configuration/cafe-secret.yaml
examples/custom-resources/custom-ip-listeners/virtualserver/cafe-secret.yaml
tests/data/smoke/smoke-secret.yaml
tests/data/service-insight/secret.yaml
tests/data/dos/dos-secret.yaml
tests/data/hsts/standard-tls/hsts-ingress.yaml
tests/data/hsts/mergeable-tls/hsts-ingress.yaml
tests/data/prometheus/secret.yaml
----
CN: example.com - Expiry: Feb  6 12:21:41 2020 GMT
tests/data/wildcard-tls-secret/wildcard-tls-secret.yaml
tests/data/wildcard-tls-secret/invalid-wildcard-tls-secret.yaml
----
CN: client - Expiry: Nov 10 22:31:38 2030 GMT
examples/custom-resources/egress-mtls/egress-mtls-secret.yaml
tests/data/egress-mtls/secret/tls-secret.yaml
----
CN: NGINXIngressController - Expiry: Aug 31 10:13:48 2018 GMT
tests/data/annotations/grpc/annotations-ingress.yaml
----
CN: secure-app.example.com - Expiry: Nov 10 21:33:06 2030 GMT
examples/custom-resources/egress-mtls/secure-app.yaml
tests/data/common/app/secure-ca/app.yaml
----
CN: kic.nginx.com - Expiry: Apr 23 15:21:33 2025 GMT
tests/data/transport-server-tcp-load-balance/tcp-tls-secret.yaml
----
CN: virtual-server.example.com - Expiry: Nov 25 14:51:09 2021 GMT
tests/data/virtual-server-route-grpc/tls-secret.yaml
----
CN: app.example.com - Expiry: Feb 12 00:03:45 2019 GMT
tests/data/common/app/vsr/secure/single.yaml
tests/data/common/app/secure/app.yaml
tests/data/common/app/secure/secret/app-tls-secret.yaml
----
CN: virtual-server.example.com - Expiry: Oct 30 14:02:03 2024 GMT
examples/custom-resources/grpc-upstreams/greeter-secret.yaml
tests/data/virtual-server-grpc/tls-secret.yaml
tests/data/ap-waf-grpc/tls-secret.yaml
tests/data/virtual-server-grpc-mixed/tls-secret.yaml
----