nginxinc / nginx-amplify-agent

NGINX Amplify Agent
BSD 2-Clause "Simplified" License
23 stars 9 forks source link

Config analysis does not expand $hostname #29

Open dvershinin opened 6 years ago

dvershinin commented 6 years ago

With the following directive in nginx configuration:

server_name $hostname;

The Analyzer -> SSL section of Amplify reports Warning:

Names in the certificate do not match the server_name configuration.

The $hostname, once expanded matches to SSL certificate in question, and nginx is fine with it (secure padlock in browser, etc.).

But Amplify agent doesn't seem to expand this variable, thus the warning..

gshulegaard commented 6 years ago

Thanks for the report! This is a good point, it likely doesn't require any work on the agent itself, but rather involves some modification to our backend logic. I will look into how much work such a change would entail and update here with more info.

gshulegaard commented 6 years ago

Ok, so I have submitted a PR to our back end with the changes necessary for expanding this $hostname value, I will update and close this issue once it is released.