Use a common k8s API fake reader - Githubissues

nginxinc / nginx-gateway-fabric

NGINX Gateway Fabric provides an implementation for the Gateway API using NGINX as the data plane.

Apache License 2.0

488 stars 95 forks source link

Use a common k8s API fake reader #1573

Open pleshakov opened 7 months ago

pleshakov commented 7 months ago

https://github.com/nginxinc/nginx-gateway-fabric/pull/1551 telemetry package starting using https://github.com/nginxinc/nginx-gateway-fabric/blob/dca4d6432ee43403c3b815186b9b8585a2ca8a48/internal/framework/events/eventsfakes/fake_reader.go#L13 which is generated in https://github.com/nginxinc/nginx-gateway-fabric/blob/dca4d6432ee43403c3b815186b9b8585a2ca8a48/internal/framework/events/first_eventbatch_preparer.go#L28 , which creates unnecessary dependency between modules

Acceptance criteria:

Remove that unnecessary dependency

Came from https://github.com/nginxinc/nginx-gateway-fabric/pull/1551#discussion_r1486728788

github-actions[bot] commented 7 months ago

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.