search

nginxinc / nginx-gateway-fabric

NGINX Gateway Fabric provides an implementation for the Gateway API using NGINX as the data plane.
Apache License 2.0
475 stars 91 forks source link

Longevity test runner doesn't use NGINX Plus image #1703

Closed pleshakov closed 6 months ago

pleshakov commented 6 months ago

Running longevity tests using:

 make start-longevity-test PLUS_ENABLED=true

with vars.env like below:

TAG=edge
PREFIX=<redacted>/nginx-gateway-fabric
NGINX_PREFIX=<redacted>/nginx-gateway-fabric/nginx
NGINX_PLUS_PREFIX=<redacted>/nginx-gateway-fabric/nginx-plus

wrongly uses NGINX_PREFIX image:

make start-longevity-test PLUS_ENABLED=true
START_LONGEVITY=true /Library/Developer/CommandLineTools/usr/bin/make nfr-test
NFR=true bash scripts/run-tests-gcp-vm.sh
vars.env                                                                                                                                                                                                                                                                                                                                  100% 1024    23.0KB/s   00:00
go test -v ./suite -ginkgo.label-filter "nfr" -ginkgo.label-filter "longevity-setup" -ginkgo.v -args --gateway-api-version=1.0.0  \
        --gateway-api-prev-version=1.0.0  --image-tag=edge --version-under-test= \
        --plus-enabled=true --ngf-image-repo=<redacted>/nginx-gateway-fabric --nginx-image-repo=<redacted>/nginx \
sjberman commented 6 months ago

When running GKE-based tests, you need to set the variable in the vars.env file. The make target variables are not propagated to the VM.

pleshakov commented 6 months ago

@sjberman my bad, should have included in the description:

PLUS_ENABLED=true

However, note how it propagated to --plus-enabled=true in the ginkgo output