nginxinc / nginx-gateway-fabric

NGINX Gateway Fabric provides an implementation for the Gateway API using NGINX as the data plane.
Apache License 2.0
503 stars 97 forks source link

Implement PolicyAffected Status for ClientSettingsPolicy and ObservabilityPolicy #1761

Open kate-osborn opened 7 months ago

kate-osborn commented 7 months ago

As an HTTPRoute or Gateway owner I want to know when my object is affected by a ClientSettingsPolicy So that I know that the policy has taken effect.

Acceptance

sjberman commented 5 months ago

This also needs to work for the ObservabilityPolicy. Ideally our policy logic is general enough that it will apply everywhere.

salonichf5 commented 5 months ago

This also needs to work for the ObservabilityPolicy. Ideally our policy logic is general enough that it will apply everywhere.

Confirming that we need to add another field letting us know if ObservabilityPolicyAffected has been applied to that resource?

Also, when a PolicyAffected is added to the Conditions of a resource, it will specify the name of the Policy, be it observability or client settings? or just true or false?

sjberman commented 5 months ago

Requirements are defined here by the spec and here by our design.

Just the message should have the context as to which policy is attached.

kate-osborn commented 5 months ago

@sjberman @salonichf5 we may want to wait to implement this. There could be changes to how policies are stored on the graph once we fix #2105 and #2079, which could affect how we build the PolicyAffected statuses.

mpstefan commented 5 months ago

Blocked by #2105 #2079

kate-osborn commented 1 month ago

@mpstefan can we move this up in priority? This is an important tool for troubleshooting policies. It let's the app dev know when their route is affected by a policy applied at the gateway level.