nginxinc / nginx-gateway-fabric

NGINX Gateway Fabric provides an implementation for the Gateway API using NGINX as the data plane.
Apache License 2.0
501 stars 97 forks source link

Fix import shadowing and unchecked type assertions in test #2574

Closed lucacome closed 1 month ago

lucacome commented 1 month ago

Proposed changes

Removes shadowing of imports and adds type assertion checks in tests. A separate PR will fix type assertions in code.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes, please add a brief note that summarizes the change.

NONE
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.29%. Comparing base (a2aa4d3) to head (79fc769). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/framework/helpers/helpers.go 25.00% 2 Missing and 1 partial :warning:
internal/mode/static/manager.go 0.00% 3 Missing :warning:
internal/mode/static/handler.go 90.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2574 +/- ## ======================================= Coverage 89.29% 89.29% ======================================= Files 100 100 Lines 7633 7633 Branches 50 50 ======================================= Hits 6816 6816 Misses 761 761 Partials 56 56 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.