Closed defrank closed 1 month ago
✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.
I have hereby read the F5 CLA and agree to its terms
Hi @defrank!
Thanks for opening this pull request! Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.
Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged. See Linking a pull request to an issue and our Pull Request Guidelines for more information.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.29%. Comparing base (
56380b3
) to head (aa21572
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have hereby read the F5 CLA and agree to its terms
recheck
Proposed changes
Problem: The Helm chart example configuration for configuring
lifecycle.preStop
uses a misleading indentation that can confuse users.Solution: Updated the Helm chart's README by fixing the indentation of the example code block to showcase the proper JSON paths of
nginxGateway.lifecycle.preStop.exec.command
andnginx.lifecycle.preStop.exec.command
. ThePreStop
hook is described as havingexec
as a handler in https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#hook-handler-execution and https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/#define-poststart-and-prestop-handlers.Testing:
Successfully deployed this chart into my cluster with the updated paths:
make unit-test
make lint
make lint-helm
make generate-all
kubectl -n nginx-gateway exec deployment/gateway-nginx-gateway-fabric -c nginx -- nginx -T
make unit-test
looks like everything passed except this single failure at the end:Checklist
Release notes