Use go test as unit test runner

sjberman commented 1 month ago

Problem: Switching to using ginkgo as the test runner caused some issues with verbose output and difficulty finding test failures. This could also be exacerbated by the fact that we mix standard go test style with ginkgo framework tests.

Solution: For now, switch back to using go test as the runner, since the output is cleaner and easier to find errors.

Closes #2584

Future work: https://github.com/nginxinc/nginx-gateway-fabric/issues/2612

Checklist

Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING doc
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked that all unit tests pass after adding my changes
[ ] I have updated necessary documentation
[x] I have rebased my branch onto main
[x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes, please add a brief note that summarizes the change.

NONE

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@744ae3b). Learn more about missing BASE report. Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2613 +/- ## ======================================= Coverage ? 88.43% ======================================= Files ? 104 Lines ? 7880 Branches ? 0 ======================================= Hits ? 6969 Misses ? 854 Partials ? 57 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sjberman commented 1 month ago

Hmm, code coverage dropped significantly. Looks like it's considering fake files now?

lucacome commented 1 month ago

Hmm, code coverage dropped significantly. Looks like it's considering fake files now?

should we try to exclude them?

sjberman commented 1 month ago

should we try to exclude them?

I'm trying to figure out how to do that. Doesn't seem very straightforward. Not sure how it worked with ginkgo...

sjberman commented 1 month ago

I might just be able to configure codecov to ignore certain paths.

nginxinc / nginx-gateway-fabric