nginxinc / nginx-gateway-fabric

NGINX Gateway Fabric provides an implementation for the Gateway API using NGINX as the data plane.
Apache License 2.0
501 stars 97 forks source link

Lower upstream count for scale nfr test with nginx plus #2695

Closed bjee19 closed 3 weeks ago

bjee19 commented 3 weeks ago

Problem: We were running into infrequent test failures due to nginx plus running out of memory when scaling upstreams.

Solution: Lower the upstream count when running with nginx plus by 2% of the previous maximum. Also, ran into an issue where the test had an incorrect WithTimeout check which caused an assertion to incorrectly only run once. Will monitor future NFR runs to see if this issue persists.

Testing: Ran the nfr scale test and it passed.

Closes #2563

Checklist

Before creating a PR, run through this checklist and mark each as complete.

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes, please add a brief note that summarizes the change.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.97%. Comparing base (0a4f0fb) to head (1a13b42). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2695 +/- ## ======================================= Coverage 88.97% 88.97% ======================================= Files 110 110 Lines 8615 8615 Branches 50 50 ======================================= Hits 7665 7665 Misses 892 892 Partials 58 58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.