nginxinc / nginx-go-crossplane

A library for working with NGINX configs in Go
Apache License 2.0
59 stars 15 forks source link

Removes unnecessary exhaustivestruct linter #58

Closed ornj closed 1 year ago

ornj commented 1 year ago

Proposed changes

I don't see a good reason to keep this. Omitting struct fields to default to their empty value is how Go works. I don't see much reason to set slice fields to nil, ints to 0, etc.

The linter itself is archived and has a note in the read me that:

This linter is meant to be used only for special cases. It is not recommended to use it for all files in a project.

Our cases aren't special.

Checklist

Before creating a PR, run through this checklist and mark each as complete.