Allow parsing of geoip2 module - Githubissues

nginxinc / nginx-go-crossplane

A library for working with NGINX configs in Go

Apache License 2.0

46 stars 12 forks source link

Allow parsing of geoip2 module #64

Closed puneetsarna closed 1 year ago

puneetsarna commented 1 year ago

Proposed changes

https://docs.nginx.com/nginx/admin-guide/security-controls/controlling-access-by-geoip/ we officially recommend using GeoIP2 for allow/restricting based on location and should handle it in crossplane as well.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING document
[x] If applicable, I have added tests that prove my fix is effective or that my feature works
[x] If applicable, I have checked that any relevant tests pass after adding my changes
[x] I have updated any relevant documentation (README.md)

puneetsarna commented 1 year ago

Does it need a test to cover geoip2 being considered a map-like directive?

@ornj done. thanks for calling it out 👍