fix: update parsing logic to handle variables with braces - Githubissues

nginxinc / nginx-go-crossplane

A library for working with NGINX configs in Go

Apache License 2.0

46 stars 12 forks source link

fix: update parsing logic to handle variables with braces #66

Closed sylwang closed 1 year ago

sylwang commented 1 year ago

Proposed changes

Address 43818 so that the user can use variables with braces in the nginx config file.

update lex.go to correctly parse variables like ${foo}
add an nginx.config file in testdata for a test case of variables with braces
add a test case in parse_test.go to ensure that the parser can correctly parse variables with braces
fix the "messy" test case in lex_test.go so that values separated by spaces are tokenized

Checklist

Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING document
[x] If applicable, I have added tests that prove my fix is effective or that my feature works
[x] If applicable, I have checked that any relevant tests pass after adding my changes
[x] I have updated any relevant documentation (README.md)