add image pull secret name variable to makefile - Githubissues

nginxinc / nginx-ingress-helm-operator

NGINX Ingress Operator for NGINX and NGINX Plus Ingress Controllers. Based on the Helm chart for NGINX Ingress Controller - https://github.com/nginxinc/helm-charts

Apache License 2.0

35 stars 20 forks source link

add image pull secret name variable to makefile #359

Closed j1m-ryan closed 1 month ago

j1m-ryan commented 1 month ago

Proposed changes

Add image pull secret name variable to makefile This will add imagePullSecrets: with a secret name to the deployment.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING doc
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that all unit tests pass after adding my changes
[ ] I have updated necessary documentation
[x] I have rebased my branch onto main
[ ] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork