search

nginxinc / nginx-ldap-auth

Example of LDAP authentication using ngx_http_auth_request_module
BSD 2-Clause "Simplified" License
678 stars 202 forks source link

Missing proxy_cache_key if README.md ? #103

Open eLvErDe opened 1 year ago

eLvErDe commented 1 year ago

Hello,

I don't understand how the configuration could works by using only

proxy_cache auth_cache;
proxy_cache_valid 200 10m;

When using HTTP Basic authorization by setting:

proxy_set_header Authorization $http_authorization;

The configuration lead to anyone having access after one auth called succeeded, which is what I think such configuration is supposed to do. But it does not make any sense.

Changing the cache configuration to include the Authroization header fixes the issue:

proxy_cache auth_cache;
proxy_cache_key "$http_authorization";
proxy_cache_valid 200 10m;

Am I stupid of the documentation is lacking this additional line ?

Best regards, Adam.

oxpa commented 1 year ago

Adam, You are right and README may be improved in this regards. At the same time the example configuration contains almost exactly what you propose. Please have a look here: https://github.com/nginxinc/nginx-ldap-auth/blame/master/nginx-ldap-auth.conf#L55