search

nginxinc / nginx-ldap-auth

Example of LDAP authentication using ngx_http_auth_request_module
BSD 2-Clause "Simplified" License
681 stars 202 forks source link

Invalid option `--url` in `nginx-ldap-auth.default` #54

Closed m4rcu5 closed 5 years ago

m4rcu5 commented 5 years ago

Hi,

https://github.com/nginxinc/nginx-ldap-auth/blob/850f5ea5ca17baa57ef40bc46b0b68ca09cc59da/nginx-ldap-auth.default#L5

The variable URL includes the option --url which results in error: unrecognized arguments: --url. The abbreviated option -u works fine.

vl-homutov commented 5 years ago

works fine for me. Which python version and/or argparse module version are you using?

m4rcu5 commented 5 years ago 
~ # python -c "import argparse; import sys; print sys.version; print argparse.__version__"
2.7.13 (default, Nov 24 2017, 17:33:09)
[GCC 6.3.0 20170516]
1.1

Defaults of Debian 9.5

vl-homutov commented 5 years ago

Just tested on Debian 9 fresh image, all works fine: (package was built with uncommented URL)

user@deb uname -a
Linux deb 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux
user@deb python -c "import argparse; import sys; print sys.version; print argparse.__version__"
2.7.13 (default, Nov 24 2017, 17:33:09) 
[GCC 6.3.0 20170516]
1.1
user@deb:~$ sudo /etc/init.d/nginx-ldap-auth start
[ ok ] Starting nginx-ldap-auth (via systemctl): nginx-ldap-auth.service.
user@deb:~$ ps aux|grep nginx
nginx-l+  2580  1.5  1.4  71148 15136 ?        Ss   13:42   0:00 python2 -u /usr/bin/nginx-ldap-auth-daemon --url ldap://example.com:389

Also, it works if started manually:
user@deb ./nginx-ldap-auth-daemon.py -u foo
Start listening on localhost:8888...
^Cuser@deb ./nginx-ldap-auth-daemon.py --url foo.bar.baz
Start listening on localhost:8888...

Are you sure you are using recent version of nginx-ldap-auth ? How do you run it?

vl-homutov commented 5 years ago

Feedback timeout. If you still have problems, feel free to reopen to add more details.