search

nginxinc / nginx-ldap-auth

Example of LDAP authentication using ngx_http_auth_request_module
BSD 2-Clause "Simplified" License
678 stars 202 forks source link

Python 2 Deprecation #60

Closed mhofer117 closed 4 years ago

mhofer117 commented 5 years ago

When building the container, PIP will warn about Python 2 deprecation:

DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.

It is probably a good idea to start migrating the script(s) to python3 for future compatibility.

python deprecation countdown

ghost commented 5 years ago

Hi. I'm stuck with python 2 as well and a simple change of docker image from python:2 to python:3 didn't work, obviously. So thumb up for migrating this to Python 3.

goochjj commented 5 years ago

See PR #66

vl-homutov commented 5 years ago

Thank you for the remind, python 3 is obviously the thing that needs to be done.

speculatrix commented 5 years ago

actually, I think the first step is to get the pylint score up from just over 2 to over 9, the script is pretty fugly.

ptoews commented 4 years ago

Anything new about this? There are only 2 months until Python 2 End-of-Life.

vl-homutov commented 4 years ago

Not yet. The plan is to make last release with python2, and switch to v3 without attempts to support both. I've put tests into docker, so testing will be a bit easier. Stay tuned.

25 октября 2019 г. 19:41:32 GMT+03:00, Philipp notifications@github.com пишет:

Anything new about this? There are only 2 months until Python 2 End-of-Life.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/nginxinc/nginx-ldap-auth/issues/60#issuecomment-546426146

-- Простите за краткость, создано в K-9 Mail.

vl-homutov commented 4 years ago

Merged and updated python3 support.