nginxinc / nginx-ldap-auth

Example of LDAP authentication using ngx_http_auth_request_module
BSD 2-Clause "Simplified" License
692 stars 202 forks source link

For a company like nginx, this "reference implementation" is a shame #98

Open schittli opened 2 years ago

schittli commented 2 years ago

Hello

We really really hope that nginx inc. does a very much better job developing the nginx product than what nginx touts as a reference implementation here.

In case you haven't noticed: this implementation is not asynchronous and blocks the server. Software engineers have known solutions to this kind of programming problem for many years!

Therefore it would be at least fair if nginx inc. helps its own its customers:

  1. And explicitly point out that the "reference implementation" was developed lovelessly and bumblingly and it blocks server requests.
  2. And point out that there are projects where the developers actually tried to program a professional implementation in their spare time, e.g.: https://github.com/sepich/nginx-ldap So it's a shame, too, that a customer has to code an nginx-ldap implementation in his spare time to patch the problems of this implementation.

Thanks a lot, kind regards, Thomas

dwmcallister commented 2 years ago

Good day Thomas.

I'm Dave McAllister, in the Nginx open source side of the house. Your issue was forwarded to me.

I appreciate the concern and you taking the time to point out this issue.

I'm working with the product and engineering side to see if we can get a better resolution. However, I've taken a couple of steps to help clarify this.

Additionally, I am asking the Product/project management team for permission to add a directory for "external project of interest". I cannot make any prediction on whether that will be acceptable

davemc

sebastianhelbig commented 2 months ago

Thanks a lot for the investigation @schittli.