search

nginxinc / nginx-loadbalancer-kubernetes

A Kubernetes Controller to synchronize NGINX+ Resources with Kubernetes Ingress Resources
Apache License 2.0
58 stars 19 forks source link

SECURITY: Make the Certificates an unloggable type #145

Closed ciroque closed 10 months ago

ciroque commented 10 months ago

Describe the bug

Leaking certs in logs is not acceptable. To help ensure this doesn't happen make the Certificates type (internal/certification/certificates.go) unloggable as described here: https://www.commonfate.io/blog/prevent-logging-secrets-in-go-by-using-custom-types