nginxinc / nginx-loadbalancer-kubernetes

A Kubernetes Controller to synchronize NGINX+ Resources with Kubernetes Ingress Resources
Apache License 2.0
58 stars 19 forks source link

fix: helm Chart erros + hard coding #159

Closed abdennour closed 10 months ago

abdennour commented 10 months ago

Still hardcoding namespace because the application cannot use another namespaces . it resolves #158

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

abdennour commented 10 months ago

it solves #158

ciroque commented 10 months ago

Hello @abdennour ,

Thanks for this contribution! I will take a run through this change tomorrow and complete my review. On the surface it looks good, just need to run it into a Cluster and ensure I understand it better.

Thanks again!

abdennour commented 10 months ago

Hello @ciroque , thanks for quick & positive response to PR