nginxinc / nginx-prometheus-exporter

NGINX Prometheus Exporter for NGINX and NGINX Plus
Apache License 2.0
1.61k stars 341 forks source link

Add GitHub Action workflow for F5 CLA integration #754

Closed TasoOneAsia closed 2 months ago

TasoOneAsia commented 3 months ago

Proposed changes

An updated version of #661 that includes a GitHub action workflow integrating the F5 CLA into the typical GitHub pull-request flow for individual contributors.

As part of this workflow's configuration, the following usernames were marked as F5 maintainers:

Checklist

Before creating a PR, run through this checklist and mark each as complete.

lucacome commented 2 months ago

I don't know if @pleshakov still wants to be a maintainer

TasoOneAsia commented 2 months ago

@lucacome I can remove him from this changeset if desired. However, there isn't much of a net-negative to being listed, all it does is prevents the bot from being implicitly triggered to prompt for a CLA upon a PR to main.

In an ideal world, the maintainer allowlist would be defined at the organization level instead of per-project, but our chosen solution does not have that functionality for the timebeing.

lucacome commented 2 months ago

@TasoOneAsia sounds good to me to leave him there.

Is this ready to be merged?

TasoOneAsia commented 2 months ago

@lucacome yup, all set on my side 👍