search

nginxinc / nginx-s3-gateway

NGINX S3 Caching Gateway
Apache License 2.0
515 stars 127 forks source link

Issue #206 -ec2 check to support IMDSv1 and IMDSv2 + moving env vars to conf file #212

Closed orensharoni closed 8 months ago

orensharoni commented 8 months ago

we added support of IMDSv2 to the EC2 check with a fall back to IMDSv1, also, some nginx env declarations were moved from the environment file to the nginx.conf file

4141done commented 8 months ago

Thank you for your contribution, @orensharoni - have been able to verify that this fixes your issue from https://github.com/nginxinc/nginx-s3-gateway/issues/206 ?

I'll stand up an ec2 env and give it a check too.

orensharoni commented 8 months ago

yes, I used it on my dev setup and the ec2 test and deployment work, the access_key and access_token should be also verified if posible

4141done commented 8 months ago

yes, I used it on my dev setup and the ec2 test and deployment work, the access_key and access_token should be also verified if posible

Excellent, thank you for confirming. I'll do a quick check on my end and then merge