fix: always redownload the NGINX GPG signing key in the NGINX OSS Dockerfile - Githubissues

nginxinc / nginx-s3-gateway

NGINX S3 Caching Gateway

Apache License 2.0

488 stars 127 forks source link

fix: always redownload the NGINX GPG signing key in the NGINX OSS Dockerfile #270

Closed alessfg closed 2 months ago

alessfg commented 2 months ago

Proposed changes

This PR does two things:

Modifies the S3 Gateway NGINX OSS Dockerfile to redownload the NGINX GPG signing key in order to avoid issues with expired signing keys.
Refactors the Dockerfile into a more sensible structure. Splits the RUN block into a block dedicated to installing NJS (which should remain relatively static) and a block dedicated to update the actual NJS S3 Gateway codebase.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

[x] I have read the contributing guidelines.
[x] I have signed the F5 Contributor License Agreement (CLA).
[x] If applicable, I have added tests that prove my fix is effective or that my feature works.
[x] If applicable, I have checked that any relevant tests pass after adding my changes.
[x] I have updated any relevant documentation (e.g. README.md).