nginxinc / ngx-rust

Rust binding for NGINX
Apache License 2.0
731 stars 60 forks source link

feat: unsafe updates for raw pointer arguments #38

Closed f5yacobucci closed 1 year ago

f5yacobucci commented 1 year ago

Dereferencing raw pointers is inherently unsafe. To satisfy clippy these functions and their callers require an unsafe indicator.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

f5yacobucci commented 1 year ago

This changes the safety designation of some functions to satisfy clippy.

Since this is a breaking change for consumers I'd like to discuss alternative approaches, but I couldn't find one in a timely manner.