feat: build script support earlier Nginx version

nginxinc / ngx-rust

Rust binding for NGINX

Apache License 2.0

713 stars 59 forks source link

feat: build script support earlier Nginx version #69

Closed JyJyJcr closed 3 months ago

JyJyJcr commented 3 months ago

Proposed changes

This PR enforces the build script of nginx-sys to download and use earlier versions of Nginx and its dependencies. This enables to build backports version targeted to LTS releases of Linux distributions. (ex. Ubuntu 22.04LTS provides a patched version of Nginx 1.18.0.)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

[x] I have written my commit messages in the Conventional Commits format.
[x] I have read the CONTRIBUTING doc
[x] I have added tests (when possible) that prove my fix is effective or that my feature works
[x] I have checked that all unit tests pass after adding my changes
[x] I have updated necessary documentation
[x] I have rebased my branch onto master
[x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

JyJyJcr commented 3 months ago

Thank you for your reviewing. I use this SDK and host Debian repository in this repository. I chose this to use Rust's type safety, crate's ecosystem, and cargo's automation. These features greatly saved my time.

dekobon commented 3 months ago

Thank you for your reviewing. I use this SDK and host Debian repository in this repository. I chose this to use Rust's type safety, crate's ecosystem, and cargo's automation. These features greatly saved my time.

Thank you for sharing. I've taken your changes, fixed a clippy warning, and bundled it into this PR and merged it.

Two more questions:

Would you mind if I link to your ngx-strict-sni project from the SDK's README?
もしかして、日本の方ですか

dekobon commented 3 months ago

Merged in https://github.com/nginxinc/ngx-rust/pull/71

JyJyJcr commented 3 months ago

Not at All! Please feel free to use it. The one problem is that I haven't checking about the license of the code, so please contact me if you need to "sanitize" it.
Yes. Sorry if my bad English annoyed you.

dekobon commented 3 months ago

Yes. Sorry if my bad English annoyed you.

Not at all. I was just happy to see a contributor from Japan. いえいえ、完璧でした。ただ、GitHubでは、めったに日本人と接することなくて、嬉しかったです。よろしくお願いします〜！NGINXに関することのなんで聞いてください。

JyJyJcr commented 3 months ago

いえいえ、完璧でした。ただ、GitHubでは、めったに日本人と接することなくて、嬉しかったです。よろしくお願いします〜！NGINXに関することのなんで聞いてください。

Wow, I'm surprised to your Japanese skill! I found in your profile that you are a language-lover. 急に流暢な日本語が出てきてびっくりしました！こちらこそよろしくお願いします。