Findtag command allowing users to find tags that cannot be added

[ngjianyi]

Steps to replicate: findtag landlords Expected: Error thrown regarding an invalid tag that cannot be added Actual: Listed 0 clients

The UG stated that the list of possible tags are in that list, yet the command allows finding for a tag that cannot be added due to the restrictions of the add and listing add commands. Without throwing an error, the user may not understand why no results are appearing, if he spelt one of the tags wrong.

[nus-pe-bot]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid input accepted for findtag command

Trying to find a tag that is not in the list of possible tags in the tag table of the User Guide does not return an error, and the app will attempt to find contacts with that invalid tag.

---

_{[original: nus-cs2103-AY2425S1/pe-interim#2896] [original labels: type.FeatureFlaw severity.Low]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your bug report. However, our team feels that the command works as intended, and gives back a valid result. If there is no one found with the specified tag, there will logically be 0 people listed. It does not affect which tags can be added to a contact.

In your example, since it found no one with the appropriate tags test, it did report the correct results accordingly as expected. This does not cause any inconvenience to the user, nor does it adversely affect the functionality of the app.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Thank you for your feedback, I acknowledge that the feature is working as intended according to the UG. However, it does not make sense from a user's perspective to be restricted to a certain set of tags when adding clients and properties, yet the `findtag` feature does not have limitations on the tags that can be used to filter by. I believe that because of this, it can cause some inconvenience to users when they are trying to use the `findtag` command. For example, if a user is trying to filter by a certain tag but has misspelt it, the user may not realise that because of the spelling error of the tag, 0 clients are listed. Instead, it would be reasonable for the user to think that there are 0 clients matching the tag, when in fact the reason it is displaying 0 clients is because of a small spelling mistake, which may not be consistent with the results if the tag was spelt correctly. Hence, I believe that this feature has some room for improvement to improve the user experience. 

---