ngld / OverlayPlugin

Yet another OverlayPlugin fork.
Other
231 stars 39 forks source link

Feature request: Map change event and target change events #247

Open xpdota opened 2 years ago

xpdota commented 2 years ago

I would like to request a couple events:

First one: Map change. Basically, same as ChangeZone, but for map changes instead of zone changes. This is currently accessible indirectly by subscribing to LogLines, but a plugin that subscribes in that manner won't have any idea what map you're in until another map change event comes in. In order to overcome this, it would need to return initial values upon subscribing like ChangeZone. Maps often make more sense than zones for things like triggers and timelines, since it lets you separate the triggers by individual boss fight for dungeons and such.

Second: Something like EnmityTargetData and EnmityAggroList, that just informs you when any entity changes targets. Could be as simple as:

{
  "type": "ChangeTarget",
  "entity": 1234,
  "newTarget": 5678  // or null, if it no longer has a target
}

Doesn't need the rest since that's all available in getCombatants.