Fix Check for Updates button

ngld / OverlayPlugin

Yet another OverlayPlugin fork.

Other

231 stars 39 forks source link

Fix Check for Updates button #264

Closed valarnin closed 2 years ago

valarnin commented 2 years ago

Fixes #263. Probably there's a better way to do this but I'm not very familiar with C# reflection code, so I just went with what worked.

quisquous commented 2 years ago

In the interim, could cactbot have a Cactbot.ILogger type that is ILogger that would keep this working from the cactbot side until this lands?

valarnin commented 2 years ago

I don't think it will, because of the way it's looking for the constructor as far as I understand it.

It'll only match the exact interface specified, so cactbot would have to switch back to the extended ILogger interface and we'd be back to square one/the chicken and egg problem we have here.

Maybe there's a different way to target the constructor in question, but as I stated above, I'm not very familiar with C# reflection.