load_mocat_sample - missing pair.2 fails, missing pair.1 succeeds

[unode]

If the folder contains:

sample
├── sample.pair.1.fq.bz2
└── sample.single.fq.bz2

using load_mocat_sample() fails with the error:

Cannot find match for file: sample/sample.pair.1.fq.bz2

However in the case of:

sample
├── sample.pair.2.fq.bz2
└── sample.single.fq.bz2

it succeeds with:

(...) load_mocat_sample found single-end sample 'sample/sample.pair.2.fq.bz2'
(...) load_mocat_sample found single-end sample 'sample/sample.single.fq.bz2'

Should we also fail here due to an unpaired pair.2 and be symmetrical with the pair.1 case?

[luispedro]

It's a strange corner case, but I think it could be a good thing to at least issue a warning.

[unode]

Would you oppose making it into an error instead of warning? Rationale being that if it matches pair.X but there's no pair.Y something unexpected happened and the warning might go by unnoticed.

[luispedro]

No objection. Never silently screw up is one of the principles that we try to adhere to and I can see how a warning may be too tame.

[unode]

I'll make it into an error then as soon as I find the time. Thanks for the feedback.

[unode]

As of 68188edd1909fe773f0e60ac72ee63e2b22afeff an error will be raised if pair.2 exists but pair.1 doesn't.